Skip to content

Commit a992197

Browse files
Philipp Stannerbroonie
authored andcommitted
spi: Replace deprecated PCI functions
pcim_iomap_table() and pcim_request_regions() have been deprecated in commit e354bb8 ("PCI: Deprecate pcim_iomap_table(), pcim_iomap_regions_request_all()"). Replace these functions with pcim_iomap_region(). Signed-off-by: Philipp Stanner <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 1d43478 commit a992197

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

drivers/spi/spi-dw-pci.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,14 @@ static int dw_spi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *en
9898
dws->paddr = pci_resource_start(pdev, pci_bar);
9999
pci_set_master(pdev);
100100

101-
ret = pcim_iomap_regions(pdev, 1 << pci_bar, pci_name(pdev));
102-
if (ret)
103-
return ret;
104-
105101
ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
106102
if (ret < 0)
107103
return ret;
108104

109-
dws->regs = pcim_iomap_table(pdev)[pci_bar];
105+
dws->regs = pcim_iomap_region(pdev, pci_bar, pci_name(pdev));
106+
if (IS_ERR(dws->regs))
107+
return PTR_ERR(dws->regs);
108+
110109
dws->irq = pci_irq_vector(pdev, 0);
111110

112111
/*

drivers/spi/spi-loongson-pci.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,11 @@ static int loongson_spi_pci_register(struct pci_dev *pdev,
1919
if (ret < 0)
2020
return dev_err_probe(dev, ret, "cannot enable pci device\n");
2121

22-
ret = pcim_iomap_regions(pdev, BIT(pci_bar), pci_name(pdev));
22+
reg_base = pcim_iomap_region(pdev, pci_bar, pci_name(pdev));
23+
ret = PTR_ERR_OR_ZERO(reg_base);
2324
if (ret)
2425
return dev_err_probe(dev, ret, "failed to request and remap memory\n");
2526

26-
reg_base = pcim_iomap_table(pdev)[pci_bar];
27-
2827
ret = loongson_spi_init_controller(dev, reg_base);
2928
if (ret)
3029
return dev_err_probe(dev, ret, "failed to initialize controller\n");

drivers/spi/spi-pxa2xx-pci.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,18 +273,16 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev,
273273
if (ret)
274274
return ret;
275275

276-
ret = pcim_iomap_regions(dev, 1 << 0, "PXA2xx SPI");
277-
if (ret)
278-
return ret;
279-
280276
pdata = devm_kzalloc(&dev->dev, sizeof(*pdata), GFP_KERNEL);
281277
if (!pdata)
282278
return -ENOMEM;
283279

284280
ssp = &pdata->ssp;
285281
ssp->dev = &dev->dev;
286282
ssp->phys_base = pci_resource_start(dev, 0);
287-
ssp->mmio_base = pcim_iomap_table(dev)[0];
283+
ssp->mmio_base = pcim_iomap_region(dev, 0, "PXA2xx SPI");
284+
if (IS_ERR(ssp->mmio_base))
285+
return PTR_ERR(ssp->mmio_base);
288286

289287
info = (struct pxa_spi_info *)ent->driver_data;
290288
ret = info->setup(dev, pdata);

0 commit comments

Comments
 (0)