Skip to content

Commit a9cdc1c

Browse files
James-A-Clarkacmel
authored andcommitted
perf tests: Remove bash construct from record+zstd_comp_decomp.sh
Commit 463538a ("perf tests: Fix test 68 zstd compression for s390") inadvertently removed the -g flag from all platforms rather than just s390, because the [[ ]] construct fails in sh. Changing to single brackets restores testing of call graphs and removes the following error from the output: $ ./perf test -v 85 85: Zstd perf.data compression/decompression : --- start --- test child forked, pid 50643 Collecting compressed record file: ./tests/shell/record+zstd_comp_decomp.sh: 15: [[: not found Fixes: 463538a ("perf tests: Fix test 68 zstd compression for s390") Signed-off-by: James Clark <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Florian Fainelli <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: John Fastabend <[email protected]> Cc: KP Singh <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Martin KaFai Lau <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Song Liu <[email protected]> Cc: Sumanth Korikkar <[email protected]> Cc: Thomas Richter <[email protected]> Cc: Yonghong Song <[email protected]> Cc: [email protected] Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent c8b9476 commit a9cdc1c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/perf/tests/shell/record+zstd_comp_decomp.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ skip_if_no_z_record() {
1212

1313
collect_z_record() {
1414
echo "Collecting compressed record file:"
15-
[[ "$(uname -m)" != s390x ]] && gflag='-g'
15+
[ "$(uname -m)" != s390x ] && gflag='-g'
1616
$perf_tool record -o $trace_file $gflag -z -F 5000 -- \
1717
dd count=500 if=/dev/urandom of=/dev/null
1818
}

0 commit comments

Comments
 (0)