cifs: remove redundant assignment to pointer pneg_ctxt

Colin Ian King · smfrench · commit a9f76cf82719 · 2019-12-02T16:55:08.000-06:00
The pointer pneg_ctxt is being initialized with a value that is never
read and it is being updated later with a new value.  The assignment
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
@@ -554,7 +554,7 @@ static void
 assemble_neg_contexts(struct smb2_negotiate_req *req,
 		      struct TCP_Server_Info *server, unsigned int *total_len)
 {
-	char *pneg_ctxt = (char *)req;
+	char *pneg_ctxt;
 	unsigned int ctxt_len;
 
 	if (*total_len > 200) {

Original file line number	Diff line number	Diff line change
`@@ -554,7 +554,7 @@ static void`
`554`	`554`	`assemble_neg_contexts(struct smb2_negotiate_req *req,`
`555`	`555`	`struct TCP_Server_Info server, unsigned int total_len)`
`556`	`556`	`{`
`557`		`- char pneg_ctxt = (char )req;`
	`557`	`+ char *pneg_ctxt;`
`558`	`558`	`unsigned int ctxt_len;`
`559`	`559`
`560`	`560`	`if (*total_len > 200) {`