usb: typec: ucsi: acpi: fix a NULL vs IS_ERR() check in probe

Dan Carpenter · rafaeljw · commit a9face899413 · 2022-05-30T18:03:38.000+02:00
The devm_memremap() function never returns NULL. It returns error pointers. Fixes: cdc3d2a ("usb: typec: ucsi: acpi: Map the mailbox with memremap()") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
@@ -133,8 +133,8 @@ static int ucsi_acpi_probe(struct platform_device *pdev)
 	}
 
 	ua->base = devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB);
-	if (!ua->base)
-		return -ENOMEM;
+	if (IS_ERR(ua->base))
+		return PTR_ERR(ua->base);
 
 	ret = guid_parse(UCSI_DSM_UUID, &ua->guid);
 	if (ret)

Original file line number	Diff line number	Diff line change
`@@ -133,8 +133,8 @@ static int ucsi_acpi_probe(struct platform_device *pdev)`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`ua->base = devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB);`
`136`		`- if (!ua->base)`
`137`		`- return -ENOMEM;`
	`136`	`+ if (IS_ERR(ua->base))`
	`137`	`+ return PTR_ERR(ua->base);`
`138`	`138`
`139`	`139`	`ret = guid_parse(UCSI_DSM_UUID, &ua->guid);`
`140`	`140`	`if (ret)`