Skip to content

Commit aa0c315

Browse files
jason-jh.linChun-Kuang Hu
authored andcommitted
drm/mediatek: Rename the define of register offset
Add DISP_REG prefix for the define of register offset to make the difference from the define of register value. Signed-off-by: jason-jh.lin <[email protected]> Signed-off-by: Chun-Kuang Hu <[email protected]>
1 parent 007f26e commit aa0c315

File tree

1 file changed

+32
-30
lines changed

1 file changed

+32
-30
lines changed

drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c

Lines changed: 32 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,22 @@
2020
#include "mtk_drm_ddp_comp.h"
2121
#include "mtk_drm_crtc.h"
2222

23-
#define DISP_OD_EN 0x0000
24-
#define DISP_OD_CFG 0x0020
25-
#define DISP_OD_SIZE 0x0030
26-
#define DISP_DITHER_5 0x0114
27-
#define DISP_DITHER_7 0x011c
28-
#define DISP_DITHER_15 0x013c
29-
#define DISP_DITHER_16 0x0140
23+
#define DISP_REG_OD_EN 0x0000
24+
#define DISP_REG_OD_CFG 0x0020
25+
#define DISP_REG_OD_SIZE 0x0030
26+
#define DISP_REG_DITHER_5 0x0114
27+
#define DISP_REG_DITHER_7 0x011c
28+
#define DISP_REG_DITHER_15 0x013c
29+
#define DISP_REG_DITHER_16 0x0140
3030

3131
#define DISP_REG_UFO_START 0x0000
3232

33-
#define DISP_DITHER_EN 0x0000
33+
#define DISP_REG_DITHER_EN 0x0000
3434
#define DITHER_EN BIT(0)
35-
#define DISP_DITHER_CFG 0x0020
35+
#define DISP_REG_DITHER_CFG 0x0020
3636
#define DITHER_RELAY_MODE BIT(0)
3737
#define DITHER_ENGINE_EN BIT(1)
38-
#define DISP_DITHER_SIZE 0x0030
38+
#define DISP_REG_DITHER_SIZE 0x0030
3939

4040
#define OD_RELAYMODE BIT(0)
4141

@@ -50,11 +50,11 @@
5050
#define DITHER_LSB_ERR_SHIFT_G(x) (((x) & 0x7) << 12)
5151
#define DITHER_ADD_LSHIFT_G(x) (((x) & 0x7) << 4)
5252

53-
#define DISP_POSTMASK_EN 0x0000
53+
#define DISP_REG_POSTMASK_EN 0x0000
5454
#define POSTMASK_EN BIT(0)
55-
#define DISP_POSTMASK_CFG 0x0020
55+
#define DISP_REG_POSTMASK_CFG 0x0020
5656
#define POSTMASK_RELAY_MODE BIT(0)
57-
#define DISP_POSTMASK_SIZE 0x0030
57+
#define DISP_REG_POSTMASK_SIZE 0x0030
5858

5959
struct mtk_ddp_comp_dev {
6060
struct clk *clk;
@@ -130,19 +130,19 @@ void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *cmdq_reg,
130130
return;
131131

132132
if (bpc >= MTK_MIN_BPC) {
133-
mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_5);
134-
mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_7);
133+
mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_REG_DITHER_5);
134+
mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_REG_DITHER_7);
135135
mtk_ddp_write(cmdq_pkt,
136136
DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) |
137137
DITHER_ADD_LSHIFT_R(MTK_MAX_BPC - bpc) |
138138
DITHER_NEW_BIT_MODE,
139-
cmdq_reg, regs, DISP_DITHER_15);
139+
cmdq_reg, regs, DISP_REG_DITHER_15);
140140
mtk_ddp_write(cmdq_pkt,
141141
DITHER_LSB_ERR_SHIFT_B(MTK_MAX_BPC - bpc) |
142142
DITHER_ADD_LSHIFT_B(MTK_MAX_BPC - bpc) |
143143
DITHER_LSB_ERR_SHIFT_G(MTK_MAX_BPC - bpc) |
144144
DITHER_ADD_LSHIFT_G(MTK_MAX_BPC - bpc),
145-
cmdq_reg, regs, DISP_DITHER_16);
145+
cmdq_reg, regs, DISP_REG_DITHER_16);
146146
mtk_ddp_write(cmdq_pkt, dither_en, cmdq_reg, regs, cfg);
147147
}
148148
}
@@ -162,16 +162,16 @@ static void mtk_od_config(struct device *dev, unsigned int w,
162162
{
163163
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
164164

165-
mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_OD_SIZE);
166-
mtk_ddp_write(cmdq_pkt, OD_RELAYMODE, &priv->cmdq_reg, priv->regs, DISP_OD_CFG);
167-
mtk_dither_set(dev, bpc, DISP_OD_CFG, cmdq_pkt);
165+
mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_REG_OD_SIZE);
166+
mtk_ddp_write(cmdq_pkt, OD_RELAYMODE, &priv->cmdq_reg, priv->regs, DISP_REG_OD_CFG);
167+
mtk_dither_set(dev, bpc, DISP_REG_OD_CFG, cmdq_pkt);
168168
}
169169

170170
static void mtk_od_start(struct device *dev)
171171
{
172172
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
173173

174-
writel(1, priv->regs + DISP_OD_EN);
174+
writel(1, priv->regs + DISP_REG_OD_EN);
175175
}
176176

177177
static void mtk_ufoe_start(struct device *dev)
@@ -187,24 +187,26 @@ static void mtk_dither_config(struct device *dev, unsigned int w,
187187
{
188188
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
189189

190-
mtk_ddp_write(cmdq_pkt, h << 16 | w, &priv->cmdq_reg, priv->regs, DISP_DITHER_SIZE);
191-
mtk_ddp_write(cmdq_pkt, DITHER_RELAY_MODE, &priv->cmdq_reg, priv->regs, DISP_DITHER_CFG);
192-
mtk_dither_set_common(priv->regs, &priv->cmdq_reg, bpc, DISP_DITHER_CFG,
190+
mtk_ddp_write(cmdq_pkt, h << 16 | w, &priv->cmdq_reg, priv->regs,
191+
DISP_REG_DITHER_SIZE);
192+
mtk_ddp_write(cmdq_pkt, DITHER_RELAY_MODE, &priv->cmdq_reg, priv->regs,
193+
DISP_REG_DITHER_CFG);
194+
mtk_dither_set_common(priv->regs, &priv->cmdq_reg, bpc, DISP_REG_DITHER_CFG,
193195
DITHER_ENGINE_EN, cmdq_pkt);
194196
}
195197

196198
static void mtk_dither_start(struct device *dev)
197199
{
198200
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
199201

200-
writel(DITHER_EN, priv->regs + DISP_DITHER_EN);
202+
writel(DITHER_EN, priv->regs + DISP_REG_DITHER_EN);
201203
}
202204

203205
static void mtk_dither_stop(struct device *dev)
204206
{
205207
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
206208

207-
writel_relaxed(0x0, priv->regs + DISP_DITHER_EN);
209+
writel_relaxed(0x0, priv->regs + DISP_REG_DITHER_EN);
208210
}
209211

210212
static void mtk_postmask_config(struct device *dev, unsigned int w,
@@ -214,23 +216,23 @@ static void mtk_postmask_config(struct device *dev, unsigned int w,
214216
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
215217

216218
mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs,
217-
DISP_POSTMASK_SIZE);
219+
DISP_REG_POSTMASK_SIZE);
218220
mtk_ddp_write(cmdq_pkt, POSTMASK_RELAY_MODE, &priv->cmdq_reg,
219-
priv->regs, DISP_POSTMASK_CFG);
221+
priv->regs, DISP_REG_POSTMASK_CFG);
220222
}
221223

222224
static void mtk_postmask_start(struct device *dev)
223225
{
224226
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
225227

226-
writel(POSTMASK_EN, priv->regs + DISP_POSTMASK_EN);
228+
writel(POSTMASK_EN, priv->regs + DISP_REG_POSTMASK_EN);
227229
}
228230

229231
static void mtk_postmask_stop(struct device *dev)
230232
{
231233
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
232234

233-
writel_relaxed(0x0, priv->regs + DISP_POSTMASK_EN);
235+
writel_relaxed(0x0, priv->regs + DISP_REG_POSTMASK_EN);
234236
}
235237

236238
static const struct mtk_ddp_comp_funcs ddp_aal = {

0 commit comments

Comments
 (0)