Skip to content

Commit aa50faf

Browse files
parakatorvalds
authored andcommitted
PCI: mt7621: Convert driver into 'bool'
The driver is not ready yet to be compiled as a module since it depends on some symbols not exported on MIPS. We have the following current problems: Building mips:allmodconfig ... failed -------------- Error log: ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! Temporarily move from 'tristate' to 'bool' until a better solution is ready. Also RALINK is redundant because SOC_MT7621 already depends on it. Hence, simplify condition. Fixes: 2bdd523 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver"). Signed-off-by: Sergio Paracuellos <[email protected]> Reviewed-and-Tested-by: Guenter Roeck <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent e386dfc commit aa50faf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/pci/controller/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,8 @@ config PCIE_APPLE
332332
If unsure, say Y if you have an Apple Silicon system.
333333

334334
config PCIE_MT7621
335-
tristate "MediaTek MT7621 PCIe Controller"
336-
depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST)
335+
bool "MediaTek MT7621 PCIe Controller"
336+
depends on SOC_MT7621 || (MIPS && COMPILE_TEST)
337337
select PHY_MT7621_PCI
338338
default SOC_MT7621
339339
help

0 commit comments

Comments
 (0)