fscrypt: add comment for fscrypt_valid_enc_modes_v1()

ebiggers · ebiggers · commit aa9979900808 · 2022-11-25T11:22:53.000-08:00
Make it clear that nothing new should be added to this function. Signed-off-by: Eric Biggers <ebiggers@google.com> Link: https://lore.kernel.org/r/20221125192047.18916-1-ebiggers@kernel.org
diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c
@@ -61,6 +61,13 @@ fscrypt_get_dummy_policy(struct super_block *sb)
 	return sb->s_cop->get_dummy_policy(sb);
 }
 
+/*
+ * Return %true if the given combination of encryption modes is supported for v1
+ * (and later) encryption policies.
+ *
+ * Do *not* add anything new here, since v1 encryption policies are deprecated.
+ * New combinations of modes should go in fscrypt_valid_enc_modes_v2() only.
+ */
 static bool fscrypt_valid_enc_modes_v1(u32 contents_mode, u32 filenames_mode)
 {
 	if (contents_mode == FSCRYPT_MODE_AES_256_XTS &&

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,13 @@ fscrypt_get_dummy_policy(struct super_block *sb)`
`61`	`61`	`return sb->s_cop->get_dummy_policy(sb);`
`62`	`62`	`}`
`63`	`63`
	`64`	`+/*`
	`65`	`+ * Return %true if the given combination of encryption modes is supported for v1`
	`66`	`+ * (and later) encryption policies.`
	`67`	`+ *`
	`68`	`+ * Do not add anything new here, since v1 encryption policies are deprecated.`
	`69`	`+ * New combinations of modes should go in fscrypt_valid_enc_modes_v2() only.`
	`70`	`+ */`
`64`	`71`	`static bool fscrypt_valid_enc_modes_v1(u32 contents_mode, u32 filenames_mode)`
`65`	`72`	`{`
`66`	`73`	`if (contents_mode == FSCRYPT_MODE_AES_256_XTS &&`