Skip to content

Commit aaeebb3

Browse files
AaronDotchenhuacai
authored andcommitted
dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check warning for reg-names
As we know, the Loongson-2K0500 is a single-core CPU, and the core1- related register (isr1) does not exist. So "reg" and "reg-names" should be set to "minItems 2"(main nad isr0). This fixes dtbs_check warning: DTC_CHK arch/loongarch/boot/dts/loongson-2k0500-ref.dtb arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg-names: ['main', 'isr0'] is too short From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: Unevaluated properties are not allowed ('reg-names' was unexpected) From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg: [[0, 534844416, 0, 64], [0, 534843456, 0, 8]] is too short From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11440: reg-names: ['main', 'isr0'] is too short From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml Acked-by: Jiaxun Yang <[email protected]> Reviewed-by: Rob Herring <[email protected]> Signed-off-by: Binbin Zhou <[email protected]> Signed-off-by: Huacai Chen <[email protected]>
1 parent ec6b36e commit aaeebb3

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,13 @@ maintainers:
1111

1212
description: |
1313
This interrupt controller is found in the Loongson-3 family of chips and
14-
Loongson-2K1000 chip, as the primary package interrupt controller which
14+
Loongson-2K series chips, as the primary package interrupt controller which
1515
can route local I/O interrupt to interrupt lines of cores.
16+
Be aware of the following points.
17+
1.The Loongson-2K0500 is a single core CPU;
18+
2.The Loongson-2K0500/2K1000 has 64 device interrupt sources as inputs, so we
19+
need to define two nodes in dts{i} to describe the "0-31" and "32-61" interrupt
20+
sources respectively.
1621
1722
allOf:
1823
- $ref: /schemas/interrupt-controller.yaml#
@@ -33,6 +38,7 @@ properties:
3338
- const: main
3439
- const: isr0
3540
- const: isr1
41+
minItems: 2
3642

3743
interrupt-controller: true
3844

@@ -86,7 +92,8 @@ if:
8692
then:
8793
properties:
8894
reg:
89-
minItems: 3
95+
minItems: 2
96+
maxItems: 3
9097

9198
required:
9299
- reg-names

0 commit comments

Comments
 (0)