Skip to content

Commit ab0fedc

Browse files
author
Peter Zijlstra
committed
x86/copy_mc_64: Remove .fixup usage
Place the anonymous .fixup code at the tail of the regular functions. Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Josh Poimboeuf <[email protected]> Reviewed-by: Borislav Petkov <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent acba44d commit ab0fedc

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

arch/x86/lib/copy_mc_64.S

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ SYM_FUNC_START(copy_mc_fragile)
7878
xorl %eax, %eax
7979
.L_done:
8080
RET
81-
SYM_FUNC_END(copy_mc_fragile)
8281

83-
.section .fixup, "ax"
8482
/*
8583
* Return number of bytes not copied for any failure. Note that
8684
* there is no "tail" handling since the source buffer is 8-byte
@@ -105,14 +103,14 @@ SYM_FUNC_END(copy_mc_fragile)
105103
movl %ecx, %edx
106104
jmp copy_mc_fragile_handle_tail
107105

108-
.previous
109-
110106
_ASM_EXTABLE_TYPE(.L_read_leading_bytes, .E_leading_bytes, EX_TYPE_DEFAULT_MCE_SAFE)
111107
_ASM_EXTABLE_TYPE(.L_read_words, .E_read_words, EX_TYPE_DEFAULT_MCE_SAFE)
112108
_ASM_EXTABLE_TYPE(.L_read_trailing_bytes, .E_trailing_bytes, EX_TYPE_DEFAULT_MCE_SAFE)
113109
_ASM_EXTABLE(.L_write_leading_bytes, .E_leading_bytes)
114110
_ASM_EXTABLE(.L_write_words, .E_write_words)
115111
_ASM_EXTABLE(.L_write_trailing_bytes, .E_trailing_bytes)
112+
113+
SYM_FUNC_END(copy_mc_fragile)
116114
#endif /* CONFIG_X86_MCE */
117115

118116
/*
@@ -133,9 +131,7 @@ SYM_FUNC_START(copy_mc_enhanced_fast_string)
133131
/* Copy successful. Return zero */
134132
xorl %eax, %eax
135133
RET
136-
SYM_FUNC_END(copy_mc_enhanced_fast_string)
137134

138-
.section .fixup, "ax"
139135
.E_copy:
140136
/*
141137
* On fault %rcx is updated such that the copy instruction could
@@ -147,7 +143,7 @@ SYM_FUNC_END(copy_mc_enhanced_fast_string)
147143
movq %rcx, %rax
148144
RET
149145

150-
.previous
151-
152146
_ASM_EXTABLE_TYPE(.L_copy, .E_copy, EX_TYPE_DEFAULT_MCE_SAFE)
147+
148+
SYM_FUNC_END(copy_mc_enhanced_fast_string)
153149
#endif /* !CONFIG_UML */

0 commit comments

Comments
 (0)