Skip to content

Commit ab41f75

Browse files
committed
alpha: mark 'Jensen' platform as no longer broken
Ok, it almost certainly is still broken on actual hardware, but the immediate reason for it having been marked BROKEN was a build error that is fixed by just making sure the low-level IO header file is included sufficiently early that the __EXTERN_INLINE hackery takes effect. This was marked broken back in 2017 by commit 1883c9f ("alpha: mark jensen as broken"), but Ulrich Teichert made me look at it as part of my cross-build work to make sure -Werror actually does the right thing. There are lots of alpha configurations that do not build cleanly, but now it's no longer because Jensen wouldn't be buildable. That said, because the Jensen platform doesn't force PCI to be enabled (Jensen only had EISA), it ends up being somewhat interesting as a source of odd configs. Reported-by: Ulrich Teichert <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 93ff9f1 commit ab41f75

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

arch/alpha/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ config ALPHA_EIGER
199199

200200
config ALPHA_JENSEN
201201
bool "Jensen"
202-
depends on BROKEN
203202
select HAVE_EISA
204203
help
205204
DEC PC 150 AXP (aka Jensen): This is a very old Digital system - one

arch/alpha/kernel/sys_jensen.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
*
88
* Code supporting the Jensen.
99
*/
10+
#define __EXTERN_INLINE
11+
#include <asm/io.h>
12+
#include <asm/jensen.h>
13+
#undef __EXTERN_INLINE
14+
1015
#include <linux/interrupt.h>
1116
#include <linux/kernel.h>
1217
#include <linux/types.h>
@@ -17,11 +22,6 @@
1722

1823
#include <asm/ptrace.h>
1924

20-
#define __EXTERN_INLINE
21-
#include <asm/io.h>
22-
#include <asm/jensen.h>
23-
#undef __EXTERN_INLINE
24-
2525
#include <asm/dma.h>
2626
#include <asm/irq.h>
2727
#include <asm/mmu_context.h>

0 commit comments

Comments
 (0)