Skip to content

Commit ab74c7b

Browse files
committed
ext4: indicate via a block bitmap read is prefetched via a tracepoint
Modify the ext4_read_block_bitmap_load tracepoint so that it tells us whether a block bitmap is being prefetched. Signed-off-by: Theodore Ts'o <[email protected]> Reviewed-by: Artem Blagodarenko <[email protected]>
1 parent 529a781 commit ab74c7b

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

fs/ext4/balloc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ ext4_read_block_bitmap_nowait(struct super_block *sb, ext4_group_t block_group,
494494
* submit the buffer_head for reading
495495
*/
496496
set_buffer_new(bh);
497-
trace_ext4_read_block_bitmap_load(sb, block_group);
497+
trace_ext4_read_block_bitmap_load(sb, block_group, ignore_locked);
498498
bh->b_end_io = ext4_end_bitmap_read;
499499
get_bh(bh);
500500
submit_bh(REQ_OP_READ, REQ_META | REQ_PRIO |

include/trace/events/ext4.h

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1312,18 +1312,34 @@ DEFINE_EVENT(ext4__bitmap_load, ext4_mb_buddy_bitmap_load,
13121312
TP_ARGS(sb, group)
13131313
);
13141314

1315-
DEFINE_EVENT(ext4__bitmap_load, ext4_read_block_bitmap_load,
1315+
DEFINE_EVENT(ext4__bitmap_load, ext4_load_inode_bitmap,
13161316

13171317
TP_PROTO(struct super_block *sb, unsigned long group),
13181318

13191319
TP_ARGS(sb, group)
13201320
);
13211321

1322-
DEFINE_EVENT(ext4__bitmap_load, ext4_load_inode_bitmap,
1322+
TRACE_EVENT(ext4_read_block_bitmap_load,
1323+
TP_PROTO(struct super_block *sb, unsigned long group, bool prefetch),
13231324

1324-
TP_PROTO(struct super_block *sb, unsigned long group),
1325+
TP_ARGS(sb, group, prefetch),
13251326

1326-
TP_ARGS(sb, group)
1327+
TP_STRUCT__entry(
1328+
__field( dev_t, dev )
1329+
__field( __u32, group )
1330+
__field( bool, prefetch )
1331+
1332+
),
1333+
1334+
TP_fast_assign(
1335+
__entry->dev = sb->s_dev;
1336+
__entry->group = group;
1337+
__entry->prefetch = prefetch;
1338+
),
1339+
1340+
TP_printk("dev %d,%d group %u prefetch %d",
1341+
MAJOR(__entry->dev), MINOR(__entry->dev),
1342+
__entry->group, __entry->prefetch)
13271343
);
13281344

13291345
TRACE_EVENT(ext4_direct_IO_enter,

0 commit comments

Comments
 (0)