Skip to content

Commit ab93edb

Browse files
airlieddakr
authored andcommitted
nouveau/gsp: allocate enough space for all channel ids.
This probably isn't the ideal fix, but we ended up using chids sparsely, and lots of things rely on indexing into the full range, so just allocate the full range up front. The GSP code fixes 8 channels into a userd page, but we end up using a single userd page per channel so end up sparsely using the range. Fixes a few crashes seen with multiple channels. Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/277 Signed-off-by: Dave Airlie <[email protected]> Signed-off-by: Danilo Krummrich <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent cea7008 commit ab93edb

File tree

1 file changed

+1
-1
lines changed
  • drivers/gpu/drm/nouveau/nvkm/engine/fifo

1 file changed

+1
-1
lines changed

drivers/gpu/drm/nouveau/nvkm/engine/fifo/r535.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ r535_fifo_runl_ctor(struct nvkm_fifo *fifo)
539539
struct nvkm_runl *runl;
540540
struct nvkm_engn *engn;
541541
u32 cgids = 2048;
542-
u32 chids = 2048 / CHID_PER_USERD;
542+
u32 chids = 2048;
543543
int ret;
544544
NV2080_CTRL_FIFO_GET_DEVICE_INFO_TABLE_PARAMS *ctrl;
545545

0 commit comments

Comments
 (0)