Skip to content

Commit aba2b17

Browse files
floatiouskwilczynski
authored andcommitted
PCI: dw-rockchip: Describe Resizable BARs as Resizable BARs
Looking at section "11.4.4.29 USP_PCIE_RESBAR Registers Summary" in the Technical Reference Manual (TRM) for RK3588, we can see that none of the BARs are Fixed BARs, but actually Resizable BARs. I couldn't find any reference in the TRM for RK3568, but looking at the downstream PCIe endpoint driver, both RK3568 and RK3588 are treated as the same, so the BARs on RK3568 must also be Resizable BARs. Now when we actually have support for Resizable BARs, let's configure these BARs as such. Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Niklas Cassel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Manivannan Sadhasivam <[email protected]> [kwilczynski: commit log] Signed-off-by: Krzysztof Wilczyński <[email protected]>
1 parent a2fa5f9 commit aba2b17

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

drivers/pci/controller/dwc/pcie-dw-rockchip.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,12 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3568 = {
273273
.msi_capable = true,
274274
.msix_capable = true,
275275
.align = SZ_64K,
276-
.bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
277-
.bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
278-
.bar[BAR_2] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
279-
.bar[BAR_3] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
280-
.bar[BAR_4] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
281-
.bar[BAR_5] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
276+
.bar[BAR_0] = { .type = BAR_RESIZABLE, },
277+
.bar[BAR_1] = { .type = BAR_RESIZABLE, },
278+
.bar[BAR_2] = { .type = BAR_RESIZABLE, },
279+
.bar[BAR_3] = { .type = BAR_RESIZABLE, },
280+
.bar[BAR_4] = { .type = BAR_RESIZABLE, },
281+
.bar[BAR_5] = { .type = BAR_RESIZABLE, },
282282
};
283283

284284
/*
@@ -293,12 +293,12 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3588 = {
293293
.msi_capable = true,
294294
.msix_capable = true,
295295
.align = SZ_64K,
296-
.bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
297-
.bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
298-
.bar[BAR_2] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
299-
.bar[BAR_3] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
296+
.bar[BAR_0] = { .type = BAR_RESIZABLE, },
297+
.bar[BAR_1] = { .type = BAR_RESIZABLE, },
298+
.bar[BAR_2] = { .type = BAR_RESIZABLE, },
299+
.bar[BAR_3] = { .type = BAR_RESIZABLE, },
300300
.bar[BAR_4] = { .type = BAR_RESERVED, },
301-
.bar[BAR_5] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
301+
.bar[BAR_5] = { .type = BAR_RESIZABLE, },
302302
};
303303

304304
static const struct pci_epc_features *

0 commit comments

Comments
 (0)