Skip to content

Commit abaf00f

Browse files
oneukumdavem330
authored andcommitted
usb: hso: remove bogus check for EINPROGRESS
This check an inherent race. It opens a race where an error code has already been set or cleared yet the URB has not been given back. We cannot do such an optimization and must unlink unconditionally. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 11c5f6d commit abaf00f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/usb/hso.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -831,8 +831,7 @@ static void hso_net_tx_timeout(struct net_device *net, unsigned int txqueue)
831831
dev_warn(&net->dev, "Tx timed out.\n");
832832

833833
/* Tear the waiting frame off the list */
834-
if (odev->mux_bulk_tx_urb &&
835-
(odev->mux_bulk_tx_urb->status == -EINPROGRESS))
834+
if (odev->mux_bulk_tx_urb)
836835
usb_unlink_urb(odev->mux_bulk_tx_urb);
837836

838837
/* Update statistics */

0 commit comments

Comments
 (0)