Skip to content

Commit ac2561f

Browse files
committed
Merge tag 'soc-fsl-next-v5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux into arm/drivers
NXP/FSL SoC driver updates for v5.16 DPIO Driver - Code cleanup and fix compile warning RCMP and Guts Driver - Make use of the helper function devm_platform_ioremap_resource() * tag 'soc-fsl-next-v5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux: soc: fsl: dpio: rename the enqueue descriptor variable soc: fsl: dpio: use an explicit NULL instead of 0 soc: fsl: rcpm: Make use of the helper function devm_platform_ioremap_resource() soc: fsl: guts: Make use of the helper function devm_platform_ioremap_resource() Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnd Bergmann <[email protected]>
2 parents 34f3c67 + 54c8b5b commit ac2561f

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed

drivers/soc/fsl/dpio/dpio-service.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ int dpaa2_io_service_enqueue_multiple_fq(struct dpaa2_io *d,
462462
qbman_eq_desc_set_no_orp(&ed, 0);
463463
qbman_eq_desc_set_fq(&ed, fqid);
464464

465-
return qbman_swp_enqueue_multiple(d->swp, &ed, fd, 0, nb);
465+
return qbman_swp_enqueue_multiple(d->swp, &ed, fd, NULL, nb);
466466
}
467467
EXPORT_SYMBOL(dpaa2_io_service_enqueue_multiple_fq);
468468

drivers/soc/fsl/dpio/qbman-portal.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -688,9 +688,9 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,
688688
p = (s->addr_cena + QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));
689689
p[0] = cl[0] | s->eqcr.pi_vb;
690690
if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) {
691-
struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
691+
struct qbman_eq_desc *eq_desc = (struct qbman_eq_desc *)p;
692692

693-
d->dca = (1 << QB_ENQUEUE_CMD_DCA_EN_SHIFT) |
693+
eq_desc->dca = (1 << QB_ENQUEUE_CMD_DCA_EN_SHIFT) |
694694
((flags[i]) & QBMAN_EQCR_DCA_IDXMASK);
695695
}
696696
eqcr_pi++;
@@ -770,9 +770,9 @@ int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,
770770
p = (s->addr_cena + QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));
771771
p[0] = cl[0] | s->eqcr.pi_vb;
772772
if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) {
773-
struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
773+
struct qbman_eq_desc *eq_desc = (struct qbman_eq_desc *)p;
774774

775-
d->dca = (1 << QB_ENQUEUE_CMD_DCA_EN_SHIFT) |
775+
eq_desc->dca = (1 << QB_ENQUEUE_CMD_DCA_EN_SHIFT) |
776776
((flags[i]) & QBMAN_EQCR_DCA_IDXMASK);
777777
}
778778
eqcr_pi++;

drivers/soc/fsl/guts.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ static int fsl_guts_probe(struct platform_device *pdev)
140140
{
141141
struct device_node *np = pdev->dev.of_node;
142142
struct device *dev = &pdev->dev;
143-
struct resource *res;
144143
const struct fsl_soc_die_attr *soc_die;
145144
const char *machine;
146145
u32 svr;
@@ -152,8 +151,7 @@ static int fsl_guts_probe(struct platform_device *pdev)
152151

153152
guts->little_endian = of_property_read_bool(np, "little-endian");
154153

155-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
156-
guts->regs = devm_ioremap_resource(dev, res);
154+
guts->regs = devm_platform_ioremap_resource(pdev, 0);
157155
if (IS_ERR(guts->regs))
158156
return PTR_ERR(guts->regs);
159157

drivers/soc/fsl/rcpm.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,19 +146,14 @@ static const struct dev_pm_ops rcpm_pm_ops = {
146146
static int rcpm_probe(struct platform_device *pdev)
147147
{
148148
struct device *dev = &pdev->dev;
149-
struct resource *r;
150149
struct rcpm *rcpm;
151150
int ret;
152151

153152
rcpm = devm_kzalloc(dev, sizeof(*rcpm), GFP_KERNEL);
154153
if (!rcpm)
155154
return -ENOMEM;
156155

157-
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
158-
if (!r)
159-
return -ENODEV;
160-
161-
rcpm->ippdexpcr_base = devm_ioremap_resource(&pdev->dev, r);
156+
rcpm->ippdexpcr_base = devm_platform_ioremap_resource(pdev, 0);
162157
if (IS_ERR(rcpm->ippdexpcr_base)) {
163158
ret = PTR_ERR(rcpm->ippdexpcr_base);
164159
return ret;

0 commit comments

Comments
 (0)