orangefs: Fix sb refcount leak when allocate sb info failed.

Chenyuan Mi · hubcapsc · commit ac2c63757f4f · 2021-10-11T14:25:41.000-04:00
The reference counting issue happens in one exception handling
path of orangefs_mount(). When failing to allocate sb info, the
function forgets to decrease the refcount of sb increased by
sget(), causing a refcount leak.

Fix this issue by jumping to the label "free_sb_and_op" instead
of "free_op"

Signed-off-by: Chenyuan Mi &lt;cymi20@fudan.edu.cn&gt;
Signed-off-by: Xiyu Yang &lt;xiyuyang19@fudan.edu.cn&gt;
Signed-off-by: Xin Tan &lt;tanxin.ctf@gmail.com&gt;
Signed-off-by: Mike Marshall &lt;hubcap@omnibond.com&gt;
diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
@@ -526,7 +526,7 @@ struct dentry *orangefs_mount(struct file_system_type *fst,
 	sb->s_fs_info = kzalloc(sizeof(struct orangefs_sb_info_s), GFP_KERNEL);
 	if (!ORANGEFS_SB(sb)) {
 		d = ERR_PTR(-ENOMEM);
-		goto free_op;
+		goto free_sb_and_op;
 	}
 
 	ret = orangefs_fill_sb(sb,

Original file line number	Diff line number	Diff line change
`@@ -526,7 +526,7 @@ struct dentry orangefs_mount(struct file_system_type fst,`
`526`	`526`	`sb->s_fs_info = kzalloc(sizeof(struct orangefs_sb_info_s), GFP_KERNEL);`
`527`	`527`	`if (!ORANGEFS_SB(sb)) {`
`528`	`528`	`d = ERR_PTR(-ENOMEM);`
`529`		`- goto free_op;`
	`529`	`+ goto free_sb_and_op;`
`530`	`530`	`}`
`531`	`531`
`532`	`532`	`ret = orangefs_fill_sb(sb,`