Skip to content

Commit ac988c4

Browse files
igawmartinkpetersen
authored andcommitted
scsi: qla2xxx: Remove return value from qla_nvme_ls()
The function always returns QLA_SUCCESS and the caller qla2x00_start_sp() doesn't even evalute the return value. So there is no point in returning a status. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Bart Van Assche <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Reviewed-by: Roman Bolshakov <[email protected]> Reviewed-by: Himanshu Madhani <[email protected]> Signed-off-by: Daniel Wagner <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent ce9a932 commit ac988c4

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/scsi/qla2xxx/qla_iocb.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3607,11 +3607,10 @@ static void qla2x00_send_notify_ack_iocb(srb_t *sp,
36073607
/*
36083608
* Build NVME LS request
36093609
*/
3610-
static int
3610+
static void
36113611
qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt)
36123612
{
36133613
struct srb_iocb *nvme;
3614-
int rval = QLA_SUCCESS;
36153614

36163615
nvme = &sp->u.iocb_cmd;
36173616
cmd_pkt->entry_type = PT_LS4_REQUEST;
@@ -3631,8 +3630,6 @@ qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt)
36313630
cmd_pkt->rx_byte_count = cpu_to_le32(nvme->u.nvme.rsp_len);
36323631
cmd_pkt->dsd[1].length = cpu_to_le32(nvme->u.nvme.rsp_len);
36333632
put_unaligned_le64(nvme->u.nvme.rsp_dma, &cmd_pkt->dsd[1].address);
3634-
3635-
return rval;
36363633
}
36373634

36383635
static void

0 commit comments

Comments
 (0)