Skip to content

Commit ad35da9

Browse files
perezpriEnric Balletbo i Serra
authored andcommitted
platform/chrome: wilco_ec: Provide correct output format to 'h1_gpio' file
Function 'h1_gpio_get' is receiving 'val' parameter of type u64, this is being passed to 'send_ec_cmd' as type u8, thus, result is stored in least significant byte. Due to output format, the whole 'val' value was being displayed when any of the most significant bytes are different than zero. This fix will make sure only least significant byte is displayed regardless of remaining bytes value. Signed-off-by: Bernardo Perez Priego <[email protected]> Signed-off-by: Enric Balletbo i Serra <[email protected]>
1 parent 1c7c513 commit ad35da9

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/platform/chrome/wilco_ec/debugfs.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,12 @@ static int send_ec_cmd(struct wilco_ec_device *ec, u8 sub_cmd, u8 *out_val)
208208
*/
209209
static int h1_gpio_get(void *arg, u64 *val)
210210
{
211-
return send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
211+
int ret;
212+
213+
ret = send_ec_cmd(arg, SUB_CMD_H1_GPIO, (u8 *)val);
214+
if (ret == 0)
215+
*val &= 0xFF;
216+
return ret;
212217
}
213218

214219
DEFINE_DEBUGFS_ATTRIBUTE(fops_h1_gpio, h1_gpio_get, NULL, "0x%02llx\n");

0 commit comments

Comments
 (0)