Skip to content

Commit ad51126

Browse files
quic-bjorandeandersson
authored andcommitted
soc: qcom: pmic_glink: Actually communicate when remote goes down
When the pmic_glink state is UP and we either receive a protection- domain (PD) notification indicating that the PD is going down, or that the whole remoteproc is going down, it's expected that the pmic_glink client instances are notified that their function has gone DOWN. This is not what the code does, which results in the client state either not updating, or being wrong in many cases. So let's fix the conditions. Fixes: 58ef4ec ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Cc: [email protected] Reviewed-by: Heikki Krogerus <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Tested-by: Amit Pundir <[email protected]> Reviewed-by: Johan Hovold <[email protected]> Tested-by: Johan Hovold <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 11bb2ff commit ad51126

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/soc/qcom/pmic_glink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg)
191191
if (pg->pdr_state == SERVREG_SERVICE_STATE_UP && pg->ept)
192192
new_state = SERVREG_SERVICE_STATE_UP;
193193
} else {
194-
if (pg->pdr_state == SERVREG_SERVICE_STATE_UP && pg->ept)
194+
if (pg->pdr_state == SERVREG_SERVICE_STATE_DOWN || !pg->ept)
195195
new_state = SERVREG_SERVICE_STATE_DOWN;
196196
}
197197

0 commit comments

Comments
 (0)