pinctrl: npcm7xx: Add missing check for ioremap

JiangJias · linusw · commit ad6463941716 · 2023-06-09T09:42:52.000+02:00
Add check for ioremap() and return the error if it fails in order to guarantee the success of ioremap(). Fixes: 3b588e4 ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Link: https://lore.kernel.org/r/20230607095829.1345-1-jiasheng@iscas.ac.cn Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
@@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl)
 		}
 
 		pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res));
+		if (!pctrl->gpio_bank[id].base)
+			return -EINVAL;
 
 		ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4,
 				 pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,

Original file line number	Diff line number	Diff line change
`@@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl)`
`1884`	`1884`	`}`
`1885`	`1885`
`1886`	`1886`	`pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res));`
	`1887`	`+ if (!pctrl->gpio_bank[id].base)`
	`1888`	`+ return -EINVAL;`
`1887`	`1889`
`1888`	`1890`	`ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4,`
`1889`	`1891`	`pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,`