Skip to content

Commit ad68598

Browse files
committed
ASoC: dapm: Don't fold register value changes into notifications
DAPM tracks and reports the value presented to the user from DAPM controls separately to the register value, these may diverge during initialisation or when an autodisable control is in use. When writing DAPM controls we currently report that a change has occurred if either the DAPM value or the value stored in the register has changed, meaning that if the two are out of sync we may appear to report a spurious event to userspace. Since we use this folded in value for nothing other than the value reported to userspace simply drop the folding in of the register change. Signed-off-by: Mark Brown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent a0746cb commit ad68598

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

sound/soc/soc-dapm.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3437,7 +3437,6 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol,
34373437
update.val = val;
34383438
card->update = &update;
34393439
}
3440-
change |= reg_change;
34413440

34423441
ret = soc_dapm_mixer_update_power(card, kcontrol, connect,
34433442
rconnect);
@@ -3539,7 +3538,6 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol,
35393538
update.val = val;
35403539
card->update = &update;
35413540
}
3542-
change |= reg_change;
35433541

35443542
ret = soc_dapm_mux_update_power(card, kcontrol, item[0], e);
35453543

0 commit comments

Comments
 (0)