Skip to content

Commit ad922ca

Browse files
Ravulapati Vishnu vardhan raobroonie
authored andcommitted
ASoC: amd: Rectifying Unbalanced pm_runtime_enable! issue
When snd_pci_acp3x driver loads we see: WARNING kernel:snd_pci_acp3x 0000:04:00.5: Unbalanced pm_runtime_enable! at boot time. same can be observed in /var/log/messages/. Modifying pm runtime sequence for fixing unbalanced pm issue. Signed-off-by: Ravulapati Vishnu vardhan rao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent bc4be65 commit ad922ca

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

sound/soc/amd/raven/pci-acp3x.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,9 +232,7 @@ static int snd_acp3x_probe(struct pci_dev *pci,
232232
}
233233
pm_runtime_set_autosuspend_delay(&pci->dev, 2000);
234234
pm_runtime_use_autosuspend(&pci->dev);
235-
pm_runtime_set_active(&pci->dev);
236235
pm_runtime_put_noidle(&pci->dev);
237-
pm_runtime_enable(&pci->dev);
238236
pm_runtime_allow(&pci->dev);
239237
return 0;
240238

@@ -303,7 +301,7 @@ static void snd_acp3x_remove(struct pci_dev *pci)
303301
ret = acp3x_deinit(adata->acp3x_base);
304302
if (ret)
305303
dev_err(&pci->dev, "ACP de-init failed\n");
306-
pm_runtime_disable(&pci->dev);
304+
pm_runtime_forbid(&pci->dev);
307305
pm_runtime_get_noresume(&pci->dev);
308306
pci_disable_msi(pci);
309307
pci_release_regions(pci);

0 commit comments

Comments
 (0)