Skip to content

Commit adc19b2

Browse files
Finn Thaingeertu
authored andcommitted
m68k: mac: Don't send uninitialized data in IOP message reply
Clear the message reply before calling iop_complete(). This code path is not normally executed but should that happen let's arrange for consistent behaviour from the IOP. Signed-off-by: Finn Thain <[email protected]> Tested-by: Stan Johnson <[email protected]> Cc: Joshua Thompson <[email protected]> Link: https://lore.kernel.org/r/8e35df4d193b082cb6285b1f30c949ff7e30e99e.1590880333.git.fthain@telegraphics.com.au Signed-off-by: Geert Uytterhoeven <[email protected]>
1 parent 931fc82 commit adc19b2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/m68k/mac/iop.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,7 @@ static void iop_handle_recv(uint iop_num, uint chan)
449449
iop_pr_debug("unclaimed message on iop_num %d chan %d\n",
450450
iop_num, chan);
451451
iop_pr_debug("%*ph\n", IOP_MSG_LEN, msg->message);
452+
memset(msg->reply, 0, IOP_MSG_LEN);
452453
iop_complete_message(msg);
453454
}
454455
}

0 commit comments

Comments
 (0)