Skip to content

Commit add4163

Browse files
Jinjie Ruanmripard
authored andcommitted
drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic()
modprobe drm_hdmi_state_helper_test and then rmmod it, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xffffff80ccd18100 (size 128): comm "kunit_try_catch", pid 1851, jiffies 4295059695 hex dump (first 32 bytes): 57 62 00 00 80 02 90 02 f0 02 20 03 00 00 e0 01 Wb........ ..... ea 01 ec 01 0d 02 00 00 0a 00 00 00 00 00 00 00 ................ backtrace (crc c2f1aa95): [<000000000f10b11b>] kmemleak_alloc+0x34/0x40 [<000000001cd4cf73>] __kmalloc_cache_noprof+0x26c/0x2f4 [<00000000f1f3cffa>] drm_mode_duplicate+0x44/0x19c [<000000008cbeef13>] drm_display_mode_from_cea_vic+0x88/0x98 [<0000000019daaacf>] 0xffffffedc11ae69c [<000000000aad0f85>] kunit_try_run_case+0x13c/0x3ac [<00000000a9210bac>] kunit_generic_run_threadfn_adapter+0x80/0xec [<000000000a0b2e9e>] kthread+0x2e8/0x374 [<00000000bd668858>] ret_from_fork+0x10/0x20 ...... Free `mode` by using drm_kunit_display_mode_from_cea_vic() to fix it. Cc: [email protected] Fixes: 4af70f1 ("drm/tests: Add RGB Quantization tests") Acked-by: Maxime Ripard <[email protected]> Signed-off-by: Jinjie Ruan <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent 9261633 commit add4163

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ static void drm_test_check_broadcast_rgb_auto_cea_mode_vic_1(struct kunit *test)
441441
ctx = drm_kunit_helper_acquire_ctx_alloc(test);
442442
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx);
443443

444-
mode = drm_display_mode_from_cea_vic(drm, 1);
444+
mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1);
445445
KUNIT_ASSERT_NOT_NULL(test, mode);
446446

447447
drm = &priv->drm;
@@ -555,7 +555,7 @@ static void drm_test_check_broadcast_rgb_full_cea_mode_vic_1(struct kunit *test)
555555
ctx = drm_kunit_helper_acquire_ctx_alloc(test);
556556
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx);
557557

558-
mode = drm_display_mode_from_cea_vic(drm, 1);
558+
mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1);
559559
KUNIT_ASSERT_NOT_NULL(test, mode);
560560

561561
drm = &priv->drm;
@@ -671,7 +671,7 @@ static void drm_test_check_broadcast_rgb_limited_cea_mode_vic_1(struct kunit *te
671671
ctx = drm_kunit_helper_acquire_ctx_alloc(test);
672672
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx);
673673

674-
mode = drm_display_mode_from_cea_vic(drm, 1);
674+
mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1);
675675
KUNIT_ASSERT_NOT_NULL(test, mode);
676676

677677
drm = &priv->drm;
@@ -1263,7 +1263,7 @@ static void drm_test_check_output_bpc_format_vic_1(struct kunit *test)
12631263
ctx = drm_kunit_helper_acquire_ctx_alloc(test);
12641264
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx);
12651265

1266-
mode = drm_display_mode_from_cea_vic(drm, 1);
1266+
mode = drm_kunit_display_mode_from_cea_vic(test, drm, 1);
12671267
KUNIT_ASSERT_NOT_NULL(test, mode);
12681268

12691269
/*

0 commit comments

Comments
 (0)