Skip to content

Commit aec4264

Browse files
jan-kiszkaWim Van Sebroeck
authored andcommitted
watchdog: iTCO_wdt: Fix detection of SMI-off case
Obviously, the test needs to run against the register content, not its address. Fixes: cb01104 ("watchdog: iTCO_wdt: Account for rebooting on second timeout") Cc: [email protected] Reported-by: Mantas Mikulėnas <[email protected]> Signed-off-by: Jan Kiszka <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Tested-by: Mantas Mikulėnas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent a4f9581 commit aec4264

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/watchdog/iTCO_wdt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ static int iTCO_wdt_set_timeout(struct watchdog_device *wd_dev, unsigned int t)
362362
* Otherwise, the BIOS generally reboots when the SMI triggers.
363363
*/
364364
if (p->smi_res &&
365-
(SMI_EN(p) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN))
365+
(inl(SMI_EN(p)) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN))
366366
tmrval /= 2;
367367

368368
/* from the specs: */

0 commit comments

Comments
 (0)