Skip to content

Commit af2872f

Browse files
ChangSeokBaebonzini
authored andcommitted
x86: KVM: Advertise AMX-FP16 CPUID to user space
Latest Intel platform Granite Rapids has introduced a new instruction - AMX-FP16, which performs dot-products of two FP16 tiles and accumulates the results into a packed single precision tile. AMX-FP16 adds FP16 capability and also allows a FP16 GPU trained model to run faster without loss of accuracy or added SW overhead. The bit definition: CPUID.(EAX=7,ECX=1):EAX[bit 21] AMX-FP16 is on an expected-dense CPUID leaf and some other bits on this leaf have kernel usages. Given that, define this feature bit like X86_FEATURE_<name> in kernel. Considering AMX-FP16 itself has no truly kernel usages and /proc/cpuinfo has too much unreadable flags, hide this one in /proc/cpuinfo. Advertise AMX-FP16 to KVM userspace. This is safe because there are no new VMX controls or additional host enabling required for guests to use this feature. Signed-off-by: Chang S. Bae <[email protected]> Signed-off-by: Jiaxi Chen <[email protected]> Acked-by: Borislav Petkov <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 6a19d7a commit af2872f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

arch/x86/include/asm/cpufeatures.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@
309309
#define X86_FEATURE_AVX_VNNI (12*32+ 4) /* AVX VNNI instructions */
310310
#define X86_FEATURE_AVX512_BF16 (12*32+ 5) /* AVX512 BFLOAT16 instructions */
311311
#define X86_FEATURE_CMPCCXADD (12*32+ 7) /* "" CMPccXADD instructions */
312+
#define X86_FEATURE_AMX_FP16 (12*32+21) /* "" AMX fp16 Support */
312313

313314
/* AMD-defined CPU features, CPUID level 0x80000008 (EBX), word 13 */
314315
#define X86_FEATURE_CLZERO (13*32+ 0) /* CLZERO instruction */

arch/x86/kvm/cpuid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ void kvm_set_cpu_caps(void)
663663
kvm_cpu_cap_set(X86_FEATURE_SPEC_CTRL_SSBD);
664664

665665
kvm_cpu_cap_mask(CPUID_7_1_EAX,
666-
F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD)
666+
F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD) | F(AMX_FP16)
667667
);
668668

669669
kvm_cpu_cap_mask(CPUID_D_1_EAX,

0 commit comments

Comments
 (0)