Skip to content

Commit af6432c

Browse files
amboarcminyard
authored andcommitted
ipmi: kcs: Finish configuring ASPEED KCS device before enable
The interrupts were configured after the channel was enabled. Configure them beforehand so they will work. Signed-off-by: Andrew Jeffery <[email protected]> Reviewed-by: Joel Stanley <[email protected]> Reviewed-by: Haiyue Wang <[email protected]> Message-Id: <c0aba2c9dfe2d0525e9cefd37995983ead0ec242.1576462051.git-series.andrew@aj.id.au> Signed-off-by: Corey Minyard <[email protected]>
1 parent 782da92 commit af6432c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/char/ipmi/kcs_bmc_aspeed.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
268268
kcs_bmc->io_inputb = aspeed_kcs_inb;
269269
kcs_bmc->io_outputb = aspeed_kcs_outb;
270270

271+
rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
272+
if (rc)
273+
return rc;
274+
271275
dev_set_drvdata(dev, kcs_bmc);
272276

273277
aspeed_kcs_set_address(kcs_bmc, addr);
274278
aspeed_kcs_enable_channel(kcs_bmc, true);
275-
rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
276-
if (rc)
277-
return rc;
278279

279280
rc = misc_register(&kcs_bmc->miscdev);
280281
if (rc) {

0 commit comments

Comments
 (0)