Skip to content

Commit af73f23

Browse files
njavalimartinkpetersen
authored andcommitted
scsi: qla2xxx: Check valid rport returned by fc_bsg_to_rport()
Klocwork reported warning of rport maybe NULL and will be dereferenced. rport returned by call to fc_bsg_to_rport() could be NULL and dereferenced. Check valid rport returned by fc_bsg_to_rport(). Cc: [email protected] Signed-off-by: Nilesh Javali <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Himanshu Madhani <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 6b504d0 commit af73f23

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/scsi/qla2xxx/qla_bsg.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,10 @@ qla2x00_process_els(struct bsg_job *bsg_job)
283283

284284
if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
285285
rport = fc_bsg_to_rport(bsg_job);
286+
if (!rport) {
287+
rval = -ENOMEM;
288+
goto done;
289+
}
286290
fcport = *(fc_port_t **) rport->dd_data;
287291
host = rport_to_shost(rport);
288292
vha = shost_priv(host);

0 commit comments

Comments
 (0)