Skip to content

Commit af8d0f6

Browse files
Wang QingJassiBrar
authored andcommitted
mailbox: mtk: add missing of_node_put before return
Fix following coccicheck warning: WARNING: Function "for_each_child_of_node" should have of_node_put() before return. Early exits from for_each_child_of_node should decrement the node reference counter. Signed-off-by: Wang Qing <[email protected]> Signed-off-by: Jassi Brar <[email protected]>
1 parent 2453128 commit af8d0f6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/mailbox/mtk-cmdq-mailbox.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,7 @@ static int cmdq_probe(struct platform_device *pdev)
573573
cmdq->clocks[alias_id].id = clk_names[alias_id];
574574
cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
575575
if (IS_ERR(cmdq->clocks[alias_id].clk)) {
576+
of_node_put(node);
576577
return dev_err_probe(dev,
577578
PTR_ERR(cmdq->clocks[alias_id].clk),
578579
"failed to get gce clk: %d\n",

0 commit comments

Comments
 (0)