Skip to content

Commit afd7aaf

Browse files
krzkvinodkoul
authored andcommitted
phy: ti: j721e-wiz: Drop OF node reference earlier for simpler code
Drop OF node reference immediately after using it in syscon_node_to_regmap(), which is both simpler and typical/expected code pattern. Signed-off-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 27a4046 commit afd7aaf

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/phy/ti/phy-j721e-wiz.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1179,14 +1179,13 @@ static int wiz_clock_probe(struct wiz *wiz, struct device_node *node)
11791179

11801180
ret = wiz_mux_of_clk_register(wiz, clk_node, wiz->mux_sel_field[i],
11811181
clk_mux_sel[i].table);
1182+
of_node_put(clk_node);
11821183
if (ret) {
11831184
dev_err_probe(dev, ret, "Failed to register %s clock\n",
11841185
node_name);
1185-
of_node_put(clk_node);
11861186
goto err;
11871187
}
11881188

1189-
of_node_put(clk_node);
11901189
}
11911190

11921191
for (i = 0; i < wiz->clk_div_sel_num; i++) {
@@ -1199,14 +1198,12 @@ static int wiz_clock_probe(struct wiz *wiz, struct device_node *node)
11991198

12001199
ret = wiz_div_clk_register(wiz, clk_node, wiz->div_sel_field[i],
12011200
clk_div_sel[i].table);
1201+
of_node_put(clk_node);
12021202
if (ret) {
12031203
dev_err_probe(dev, ret, "Failed to register %s clock\n",
12041204
node_name);
1205-
of_node_put(clk_node);
12061205
goto err;
12071206
}
1208-
1209-
of_node_put(clk_node);
12101207
}
12111208

12121209
return 0;

0 commit comments

Comments
 (0)