Skip to content

Commit afece15

Browse files
arndbrobclark
authored andcommitted
drm: msm: fix building without CONFIG_COMMON_CLK
When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' This was only exposed after it became possible to build test the driver without the clock interfaces. Make COMMON_CLK a hard dependency for compile testing, and simplify it a little based on that. Fixes: b3ed524 ("drm/msm: allow compile_test on !ARM") Reported-by: Randy Dunlap <[email protected]> Suggested-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Rob Clark <[email protected]>
1 parent e4840d5 commit afece15

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

drivers/gpu/drm/msm/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ config DRM_MSM
44
tristate "MSM DRM"
55
depends on DRM
66
depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
7+
depends on COMMON_CLK
78
depends on IOMMU_SUPPORT
8-
depends on (OF && COMMON_CLK) || COMPILE_TEST
99
depends on QCOM_OCMEM || QCOM_OCMEM=n
1010
depends on QCOM_LLCC || QCOM_LLCC=n
1111
depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n

drivers/gpu/drm/msm/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ msm-y := \
2323
hdmi/hdmi_i2c.o \
2424
hdmi/hdmi_phy.o \
2525
hdmi/hdmi_phy_8960.o \
26+
hdmi/hdmi_phy_8996.o \
2627
hdmi/hdmi_phy_8x60.o \
2728
hdmi/hdmi_phy_8x74.o \
29+
hdmi/hdmi_pll_8960.o \
2830
edp/edp.o \
2931
edp/edp_aux.o \
3032
edp/edp_bridge.o \
@@ -37,6 +39,7 @@ msm-y := \
3739
disp/mdp4/mdp4_dtv_encoder.o \
3840
disp/mdp4/mdp4_lcdc_encoder.o \
3941
disp/mdp4/mdp4_lvds_connector.o \
42+
disp/mdp4/mdp4_lvds_pll.o \
4043
disp/mdp4/mdp4_irq.o \
4144
disp/mdp4/mdp4_kms.o \
4245
disp/mdp4/mdp4_plane.o \
@@ -116,9 +119,6 @@ msm-$(CONFIG_DRM_MSM_DP)+= dp/dp_aux.o \
116119
dp/dp_audio.o
117120

118121
msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o
119-
msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o
120-
msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_pll_8960.o
121-
msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_phy_8996.o
122122

123123
msm-$(CONFIG_DRM_MSM_HDMI_HDCP) += hdmi/hdmi_hdcp.o
124124

0 commit comments

Comments
 (0)