Skip to content

Commit aff2355

Browse files
Mark Lordbroonie
authored andcommitted
spi: pxa2xx: Fix regression when toggling chip select on LPSS devices
The commit 78b435c ("spi: pxa2xx: Introduce __lpss_ssp_update_priv() helper") broke speaker output on my ASUS UX5304MA laptop. The problem is in inverted value that got written in the private register. Simple bug, simple fix. Fixes: 78b435c ("spi: pxa2xx: Introduce __lpss_ssp_update_priv() helper") Signed-off-by: Mark Lord <[email protected]> Tested-by: Mark Lord <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 4fd2707 commit aff2355

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-pxa2xx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ static void lpss_ssp_cs_control(struct spi_device *spi, bool enable)
399399
lpss_ssp_select_cs(spi, config);
400400

401401
mask = LPSS_CS_CONTROL_CS_HIGH;
402-
__lpss_ssp_update_priv(drv_data, config->reg_cs_ctrl, mask, enable ? mask : 0);
402+
__lpss_ssp_update_priv(drv_data, config->reg_cs_ctrl, mask, enable ? 0 : mask);
403403
if (config->cs_clk_stays_gated) {
404404
/*
405405
* Changing CS alone when dynamic clock gating is on won't

0 commit comments

Comments
 (0)