Skip to content

Commit b026277

Browse files
author
Jiri Kosina
committed
Merge branch 'for-5.16/core' into for-linus
- update to handle TransducerSerialNumber2 which has been recently added to the specification (Felipe Balbi)
2 parents 820e990 + 8e3cd92 commit b026277

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

drivers/hid/hid-cougar.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,9 @@ static int cougar_bind_shared_data(struct hid_device *hdev,
179179

180180
cougar->shared = shared;
181181

182-
error = devm_add_action(&hdev->dev, cougar_remove_shared_data, cougar);
182+
error = devm_add_action_or_reset(&hdev->dev, cougar_remove_shared_data, cougar);
183183
if (error) {
184184
mutex_unlock(&cougar_udev_list_lock);
185-
cougar_remove_shared_data(cougar);
186185
return error;
187186
}
188187

drivers/hid/hid-debug.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ static const struct hid_usage_entry hid_usage_table[] = {
160160
{0, 0x59, "ButtonType"},
161161
{0, 0x5A, "SecondaryBarrelSwitch"},
162162
{0, 0x5B, "TransducerSerialNumber"},
163+
{0, 0x6e, "TransducerSerialNumber2"},
163164
{ 15, 0, "PhysicalInterfaceDevice" },
164165
{0, 0x00, "Undefined"},
165166
{0, 0x01, "Physical_Interface_Device"},
@@ -486,8 +487,7 @@ char *hid_resolv_usage(unsigned usage, struct seq_file *f) {
486487

487488
if (!f) {
488489
len = strlen(buf);
489-
snprintf(buf+len, max(0, HID_DEBUG_BUFSIZE - len), ".");
490-
len++;
490+
len += scnprintf(buf + len, HID_DEBUG_BUFSIZE - len, ".");
491491
}
492492
else {
493493
seq_printf(f, ".");
@@ -498,7 +498,7 @@ char *hid_resolv_usage(unsigned usage, struct seq_file *f) {
498498
if (p->usage == (usage & 0xffff)) {
499499
if (!f)
500500
snprintf(buf + len,
501-
max(0,HID_DEBUG_BUFSIZE - len - 1),
501+
HID_DEBUG_BUFSIZE - len,
502502
"%s", p->description);
503503
else
504504
seq_printf(f,
@@ -509,8 +509,8 @@ char *hid_resolv_usage(unsigned usage, struct seq_file *f) {
509509
break;
510510
}
511511
if (!f)
512-
snprintf(buf + len, max(0, HID_DEBUG_BUFSIZE - len - 1),
513-
"%04x", usage & 0xffff);
512+
snprintf(buf + len, HID_DEBUG_BUFSIZE - len, "%04x",
513+
usage & 0xffff);
514514
else
515515
seq_printf(f, "%04x", usage & 0xffff);
516516
return buf;

drivers/hid/hid-input.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,6 +871,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
871871
break;
872872

873873
case 0x5b: /* TransducerSerialNumber */
874+
case 0x6e: /* TransducerSerialNumber2 */
874875
usage->type = EV_MSC;
875876
usage->code = MSC_SERIAL;
876877
bit = input->mscbit;

0 commit comments

Comments
 (0)