Skip to content

Commit b02e6f7

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/dsi-cm: Don't put .remove() in .exit.text and drop suppress_bind_attrs
On today's platforms the memory savings of putting the remove function in .exit isn't that relevant any more. It only matters for built-in drivers and typically saves a few 100k. The downside is that the driver cannot be unbound at runtime which is ancient and also slightly complicates testing. Also it requires to mark the driver struct with __refdata which is needed to suppress a (W=1) modpost warning: WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm: section mismatch in reference: dsicm_driver+0x4 (section: .data) -> dsicm_remove (section: .exit.text) To simplify matters, move the remove callback to .text and drop .suppress_bind_attrs = true. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent bfaee69 commit b02e6f7

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,7 +1241,7 @@ static int dsicm_probe(struct platform_device *pdev)
12411241
return r;
12421242
}
12431243

1244-
static int __exit dsicm_remove(struct platform_device *pdev)
1244+
static int dsicm_remove(struct platform_device *pdev)
12451245
{
12461246
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
12471247
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -1282,11 +1282,10 @@ MODULE_DEVICE_TABLE(of, dsicm_of_match);
12821282

12831283
static struct platform_driver dsicm_driver = {
12841284
.probe = dsicm_probe,
1285-
.remove = __exit_p(dsicm_remove),
1285+
.remove = dsicm_remove,
12861286
.driver = {
12871287
.name = "panel-dsi-cm",
12881288
.of_match_table = dsicm_of_match,
1289-
.suppress_bind_attrs = true,
12901289
},
12911290
};
12921291

0 commit comments

Comments
 (0)