Skip to content

Commit b033575

Browse files
brookxu-txhtejun
authored andcommitted
misc_cgroup: remove error log to avoid log flood
In scenarios where containers are frequently created and deleted, a large number of error logs maybe generated. The logs only show which node is about to go over the max limit, not the node which resource request failed. As misc.events has provided relevant information, maybe we can remove this log. Signed-off-by: Chunguang Xu <[email protected]> Reviewed-by: Michal Koutný <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent f279294 commit b033575

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

include/linux/misc_cgroup.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ struct misc_res {
3737
unsigned long max;
3838
atomic_long_t usage;
3939
atomic_long_t events;
40-
bool failed;
4140
};
4241

4342
/**

kernel/cgroup/misc.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,6 @@ int misc_cg_try_charge(enum misc_res_type type, struct misc_cg *cg,
157157
new_usage = atomic_long_add_return(amount, &res->usage);
158158
if (new_usage > READ_ONCE(res->max) ||
159159
new_usage > READ_ONCE(misc_res_capacity[type])) {
160-
if (!res->failed) {
161-
pr_info("cgroup: charge rejected by the misc controller for %s resource in ",
162-
misc_res_name[type]);
163-
pr_cont_cgroup_path(i->css.cgroup);
164-
pr_cont("\n");
165-
res->failed = true;
166-
}
167160
ret = -EBUSY;
168161
goto err_charge;
169162
}

0 commit comments

Comments
 (0)