Skip to content

Commit b0e453f

Browse files
Wei YongjunMarc Zyngier
authored andcommitted
irqchip/mips-gic: Make local symbols static
The sparse tool complains as follows: drivers/irqchip/irq-mips-gic.c:49:1: warning: symbol '__pcpu_scope_pcpu_masks' was not declared. Should it be static? drivers/irqchip/irq-mips-gic.c:620:6: warning: symbol 'gic_ipi_domain_free' was not declared. Should it be static? drivers/irqchip/irq-mips-gic.c:634:5: warning: symbol 'gic_ipi_domain_match' was not declared. Should it be static? Those symbols are not used outside of irq-mips-gic.c, so marks them static. Reported-by: Hulk Robot <[email protected]> Signed-off-by: Wei Yongjun <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 45e9504 commit b0e453f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/irqchip/irq-mips-gic.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
void __iomem *mips_gic_base;
4848

49-
DEFINE_PER_CPU_READ_MOSTLY(unsigned long[GIC_MAX_LONGS], pcpu_masks);
49+
static DEFINE_PER_CPU_READ_MOSTLY(unsigned long[GIC_MAX_LONGS], pcpu_masks);
5050

5151
static DEFINE_SPINLOCK(gic_lock);
5252
static struct irq_domain *gic_irq_domain;
@@ -617,8 +617,8 @@ static int gic_ipi_domain_alloc(struct irq_domain *d, unsigned int virq,
617617
return ret;
618618
}
619619

620-
void gic_ipi_domain_free(struct irq_domain *d, unsigned int virq,
621-
unsigned int nr_irqs)
620+
static void gic_ipi_domain_free(struct irq_domain *d, unsigned int virq,
621+
unsigned int nr_irqs)
622622
{
623623
irq_hw_number_t base_hwirq;
624624
struct irq_data *data;
@@ -631,8 +631,8 @@ void gic_ipi_domain_free(struct irq_domain *d, unsigned int virq,
631631
bitmap_set(ipi_available, base_hwirq, nr_irqs);
632632
}
633633

634-
int gic_ipi_domain_match(struct irq_domain *d, struct device_node *node,
635-
enum irq_domain_bus_token bus_token)
634+
static int gic_ipi_domain_match(struct irq_domain *d, struct device_node *node,
635+
enum irq_domain_bus_token bus_token)
636636
{
637637
bool is_ipi;
638638

0 commit comments

Comments
 (0)