Skip to content

Commit b1231ff

Browse files
mbrost05Thomas Hellström
authored andcommitted
drm/xe: Mark ComputeCS read mode as UC on iGPU
RING_CMD_CCTL read index should be UC on iGPU parts due to L3 caching structure. Having this as WB blocks ULLS from being enabled. Change to UC to unblock ULLS on iGPU. v2: - Drop internal communications commnet, bspec is updated Cc: Balasubramani Vivekanandan <[email protected]> Cc: Michal Mrozek <[email protected]> Cc: Paulo Zanoni <[email protected]> Cc: José Roberto de Souza <[email protected]> Cc: [email protected] Fixes: 328e089 ("drm/xe: Leverage ComputeCS read L3 caching") Signed-off-by: Matthew Brost <[email protected]> Acked-by: Michal Mrozek <[email protected]> Reviewed-by: Stuart Summers <[email protected]> Reviewed-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 758debf) Signed-off-by: Thomas Hellström <[email protected]>
1 parent 79a21fc commit b1231ff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/xe/xe_hw_engine.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)
419419
* Bspec: 72161
420420
*/
421421
const u8 mocs_write_idx = gt->mocs.uc_index;
422-
const u8 mocs_read_idx = hwe->class == XE_ENGINE_CLASS_COMPUTE &&
422+
const u8 mocs_read_idx = hwe->class == XE_ENGINE_CLASS_COMPUTE && IS_DGFX(xe) &&
423423
(GRAPHICS_VER(xe) >= 20 || xe->info.platform == XE_PVC) ?
424424
gt->mocs.wb_index : gt->mocs.uc_index;
425425
u32 ring_cmd_cctl_val = REG_FIELD_PREP(CMD_CCTL_WRITE_OVERRIDE_MASK, mocs_write_idx) |

0 commit comments

Comments
 (0)