Skip to content

Commit b12e924

Browse files
Tetsuo HandaStefan-Schmidt
authored andcommitted
net/ieee802154: don't warn zero-sized raw_sendmsg()
syzbot is hitting skb_assert_len() warning at __dev_queue_xmit() [1], for PF_IEEE802154 socket's zero-sized raw_sendmsg() request is hitting __dev_queue_xmit() with skb->len == 0. Since PF_IEEE802154 socket's zero-sized raw_sendmsg() request was able to return 0, don't call __dev_queue_xmit() if packet length is 0. ---------- #include <sys/socket.h> #include <netinet/in.h> int main(int argc, char *argv[]) { struct sockaddr_in addr = { .sin_family = AF_INET, .sin_addr.s_addr = htonl(INADDR_LOOPBACK) }; struct iovec iov = { }; struct msghdr hdr = { .msg_name = &addr, .msg_namelen = sizeof(addr), .msg_iov = &iov, .msg_iovlen = 1 }; sendmsg(socket(PF_IEEE802154, SOCK_RAW, 0), &hdr, 0); return 0; } ---------- Note that this might be a sign that commit fd18942 ("bpf: Don't redirect packets with invalid pkt_len") should be reverted, for skb->len == 0 was acceptable for at least PF_IEEE802154 socket. Link: https://syzkaller.appspot.com/bug?extid=5ea725c25d06fb9114c4 [1] Reported-by: syzbot <[email protected]> Fixes: fd18942 ("bpf: Don't redirect packets with invalid pkt_len") Signed-off-by: Tetsuo Handa <[email protected]> Signed-off-by: Alexander Aring <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stefan Schmidt <[email protected]>
1 parent 2eb2756 commit b12e924

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

net/ieee802154/socket.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,10 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
272272
err = -EMSGSIZE;
273273
goto out_dev;
274274
}
275+
if (!size) {
276+
err = 0;
277+
goto out_dev;
278+
}
275279

276280
hlen = LL_RESERVED_SPACE(dev);
277281
tlen = dev->needed_tailroom;

0 commit comments

Comments
 (0)