Skip to content

Commit b1525d0

Browse files
committed
landlock: Remove KUnit test that triggers a warning
A KUnit test checking boundaries triggers a canary warning, which may be disturbing. Let's remove this test for now. Hopefully, KUnit will soon get support for suppressing warning backtraces [1]. Cc: Alessandro Carminati <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Günther Noack <[email protected]> Reported-by: Tingmao Wang <[email protected]> Closes: https://lore.kernel.org/r/[email protected] Link: https://lore.kernel.org/r/[email protected] [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mickaël Salaün <[email protected]>
1 parent b443265 commit b1525d0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

security/landlock/audit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ static void test_get_hierarchy(struct kunit *const test)
175175
KUNIT_EXPECT_EQ(test, 10, get_hierarchy(&dom2, 0)->id);
176176
KUNIT_EXPECT_EQ(test, 20, get_hierarchy(&dom2, 1)->id);
177177
KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, 2)->id);
178-
KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, -1)->id);
178+
/* KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, -1)->id); */
179179
}
180180

181181
#endif /* CONFIG_SECURITY_LANDLOCK_KUNIT_TEST */

0 commit comments

Comments
 (0)