Skip to content

Commit b1c3d2b

Browse files
jluebbemasahir0y
authored andcommitted
certs: Fix build error when PKCS#11 URI contains semicolon
When CONFIG_MODULE_SIG_KEY is PKCS#11 URI (pkcs11:*) and contains a semicolon, signing_key.x509 fails to build: certs/extract-cert pkcs11:token=foo;object=bar;pin-value=1111 certs/signing_key.x509 Usage: extract-cert <source> <dest> Add quotes to the extract-cert argument to avoid splitting by the shell. This approach was suggested by Masahiro Yamada <[email protected]>. Fixes: 129ab0d ("kbuild: do not quote string values in include/config/auto.conf") Signed-off-by: Jan Luebbe <[email protected]> Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 2241ab5 commit b1c3d2b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

certs/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ $(obj)/blacklist_hash_list: $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) FORCE
2323
targets += blacklist_hash_list
2424

2525
quiet_cmd_extract_certs = CERT $@
26-
cmd_extract_certs = $(obj)/extract-cert $(extract-cert-in) $@
27-
extract-cert-in = $(or $(filter-out $(obj)/extract-cert, $(real-prereqs)),"")
26+
cmd_extract_certs = $(obj)/extract-cert "$(extract-cert-in)" $@
27+
extract-cert-in = $(filter-out $(obj)/extract-cert, $(real-prereqs))
2828

2929
$(obj)/system_certificates.o: $(obj)/x509_certificate_list
3030

0 commit comments

Comments
 (0)