Skip to content

Commit b1d69bf

Browse files
author
Thomas Zimmermann
committed
drm/exynos: Use fbdev DMA helpers
Use fbdev's DMA helpers for fbdev emulation. The driver previously used the I/O-memory helpers, while allocating DMA-able system memory. This could (in theory) result in bus errors from accessing the memory range. This bug has been present since the exynos driver was first added. v2: * drop the pointless Fixes tag (Javier) * fix typo in commit message Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Javier Martinez Canillas <[email protected]> Acked-by: Inki Dae <[email protected]> Acked-by: Maxime Ripard <[email protected]> Cc: Inki Dae <[email protected]> Cc: Seung-Woo Kim <[email protected]> Cc: Kyungmin Park <[email protected]> Cc: Krzysztof Kozlowski <[email protected]> Cc: Alim Akhtar <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent ef28231 commit b1d69bf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/gpu/drm/exynos/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ config DRM_EXYNOS
77
select DRM_DISPLAY_HELPER if DRM_EXYNOS_DP
88
select DRM_KMS_HELPER
99
select VIDEOMODE_HELPERS
10-
select FB_IO_HELPERS if DRM_FBDEV_EMULATION
10+
select FB_DMA_HELPERS if DRM_FBDEV_EMULATION
1111
select SND_SOC_HDMI_CODEC if SND_SOC
1212
help
1313
Choose this option if you have a Samsung SoC Exynos chipset.

drivers/gpu/drm/exynos/exynos_drm_fbdev.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
4949

5050
static const struct fb_ops exynos_drm_fb_ops = {
5151
.owner = THIS_MODULE,
52-
__FB_DEFAULT_IO_OPS_RDWR,
52+
__FB_DEFAULT_DMA_OPS_RDWR,
5353
DRM_FB_HELPER_DEFAULT_OPS,
54-
__FB_DEFAULT_IO_OPS_DRAW,
54+
__FB_DEFAULT_DMA_OPS_DRAW,
5555
.fb_mmap = exynos_drm_fb_mmap,
5656
.fb_destroy = exynos_drm_fb_destroy,
5757
};

0 commit comments

Comments
 (0)