Skip to content

Commit b1e4286

Browse files
Viktor Mihajlovskifrankjaa
authored andcommitted
KVM: s390: pv: relax WARN_ONCE condition for destroy fast
Destroy configuration fast may return with RC 0x104 if there are still bound APQNs in the configuration. The final cleanup will occur with the standard destroy configuration UVC as at this point in time all APQNs have been reset and thus unbound. Therefore, don't warn if RC 0x104 is reported. Signed-off-by: Viktor Mihajlovski <[email protected]> Reviewed-by: Claudio Imbrenda <[email protected]> Reviewed-by: Janosch Frank <[email protected]> Reviewed-by: Steffen Eiden <[email protected]> Reviewed-by: Michael Mueller <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Janosch Frank <[email protected]> Message-ID: <[email protected]>
1 parent 5d0545a commit b1e4286

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/s390/kvm/pv.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,8 @@ static int kvm_s390_pv_deinit_vm_fast(struct kvm *kvm, u16 *rc, u16 *rrc)
285285
WRITE_ONCE(kvm->arch.gmap->guest_handle, 0);
286286
KVM_UV_EVENT(kvm, 3, "PROTVIRT DESTROY VM FAST: rc %x rrc %x",
287287
uvcb.header.rc, uvcb.header.rrc);
288-
WARN_ONCE(cc, "protvirt destroy vm fast failed handle %llx rc %x rrc %x",
288+
WARN_ONCE(cc && uvcb.header.rc != 0x104,
289+
"protvirt destroy vm fast failed handle %llx rc %x rrc %x",
289290
kvm_s390_pv_get_handle(kvm), uvcb.header.rc, uvcb.header.rrc);
290291
/* Intended memory leak on "impossible" error */
291292
if (!cc)

0 commit comments

Comments
 (0)