Skip to content

Commit b207602

Browse files
Dan Carpentersmfrench
authored andcommitted
ksmbd: uninitialized variable in create_socket()
The "ksmbd_socket" variable is not initialized on this error path. Cc: [email protected] Fixes: 0626e66 ("cifsd: add server handler for central processing and tranport layers") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 2fd5dcb commit b207602

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

fs/ksmbd/transport_tcp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ static int create_socket(struct interface *iface)
404404
&ksmbd_socket);
405405
if (ret) {
406406
pr_err("Can't create socket for ipv4: %d\n", ret);
407-
goto out_error;
407+
goto out_clear;
408408
}
409409

410410
sin.sin_family = PF_INET;
@@ -462,6 +462,7 @@ static int create_socket(struct interface *iface)
462462

463463
out_error:
464464
tcp_destroy_socket(ksmbd_socket);
465+
out_clear:
465466
iface->ksmbd_socket = NULL;
466467
return ret;
467468
}

0 commit comments

Comments
 (0)