Skip to content

Commit b29b811

Browse files
Georgi Djakovgregkh
authored andcommitted
interconnect: qcom: sdm845: Walk the list safely on node removal
As we will remove items off the list using list_del(), we need to use the safe version of list_for_each_entry(). Fixes: b5d2f74 ("interconnect: qcom: Add sdm845 interconnect provider driver") Reported-by: Dmitry Osipenko <[email protected]> Reviewed-by: Bjorn Andersson <[email protected]> Signed-off-by: Georgi Djakov <[email protected]> Cc: <[email protected]> # v5.3+ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e27da6a commit b29b811

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/interconnect/qcom/sdm845.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -868,9 +868,9 @@ static int qnoc_remove(struct platform_device *pdev)
868868
{
869869
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
870870
struct icc_provider *provider = &qp->provider;
871-
struct icc_node *n;
871+
struct icc_node *n, *tmp;
872872

873-
list_for_each_entry(n, &provider->nodes, node_list) {
873+
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
874874
icc_node_del(n);
875875
icc_node_destroy(n->id);
876876
}

0 commit comments

Comments
 (0)