Skip to content

Commit b2b1d94

Browse files
jbeulichsuryasaimadhu
authored andcommitted
x86/entry/64: Add instruction suffix to SYSRET
ignore_sysret() contains an unsuffixed SYSRET instruction. gas correctly interprets this as SYSRETL, but leaving it up to gas to guess when there is no register operand that implies a size is bad practice, and upstream gas is likely to warn about this in the future. Use SYSRETL explicitly. This does not change the assembled output. Signed-off-by: Jan Beulich <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Acked-by: Andy Lutomirski <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 2b10906 commit b2b1d94

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/entry/entry_64.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1728,7 +1728,7 @@ SYM_CODE_END(nmi)
17281728
SYM_CODE_START(ignore_sysret)
17291729
UNWIND_HINT_EMPTY
17301730
mov $-ENOSYS, %eax
1731-
sysret
1731+
sysretl
17321732
SYM_CODE_END(ignore_sysret)
17331733
#endif
17341734

0 commit comments

Comments
 (0)