Skip to content

Commit b340db7

Browse files
Wolfram SangAndi Shyti
authored andcommitted
i2c: rk3x: reword according to newest specification
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 specifications and replace "master/slave" with more appropriate terms. Signed-off-by: Wolfram Sang <[email protected]> Reviewed-by: Heiko Stuebner <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Signed-off-by: Andi Shyti <[email protected]>
1 parent e1571b1 commit b340db7

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/i2c/busses/i2c-rk3x.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
/* Register Map */
2929
#define REG_CON 0x00 /* control register */
3030
#define REG_CLKDIV 0x04 /* clock divisor register */
31-
#define REG_MRXADDR 0x08 /* slave address for REGISTER_TX */
32-
#define REG_MRXRADDR 0x0c /* slave register address for REGISTER_TX */
31+
#define REG_MRXADDR 0x08 /* target address for REGISTER_TX */
32+
#define REG_MRXRADDR 0x0c /* target register address for REGISTER_TX */
3333
#define REG_MTXCNT 0x10 /* number of bytes to be transmitted */
3434
#define REG_MRXCNT 0x14 /* number of bytes to be received */
3535
#define REG_IEN 0x18 /* interrupt enable */
@@ -68,8 +68,8 @@ enum {
6868
/* REG_IEN/REG_IPD bits */
6969
#define REG_INT_BTF BIT(0) /* a byte was transmitted */
7070
#define REG_INT_BRF BIT(1) /* a byte was received */
71-
#define REG_INT_MBTF BIT(2) /* master data transmit finished */
72-
#define REG_INT_MBRF BIT(3) /* master data receive finished */
71+
#define REG_INT_MBTF BIT(2) /* controller data transmit finished */
72+
#define REG_INT_MBRF BIT(3) /* controller data receive finished */
7373
#define REG_INT_START BIT(4) /* START condition generated */
7474
#define REG_INT_STOP BIT(5) /* STOP condition generated */
7575
#define REG_INT_NAKRCV BIT(6) /* NACK received */
@@ -184,7 +184,7 @@ struct rk3x_i2c_soc_data {
184184
* @wait: the waitqueue to wait for i2c transfer
185185
* @busy: the condition for the event to wait for
186186
* @msg: current i2c message
187-
* @addr: addr of i2c slave device
187+
* @addr: addr of i2c target device
188188
* @mode: mode of i2c transfer
189189
* @is_last_msg: flag determines whether it is the last msg in this transfer
190190
* @state: state of i2c transfer
@@ -979,7 +979,7 @@ static int rk3x_i2c_setup(struct rk3x_i2c *i2c, struct i2c_msg *msgs, int num)
979979
/*
980980
* The I2C adapter can issue a small (len < 4) write packet before
981981
* reading. This speeds up SMBus-style register reads.
982-
* The MRXADDR/MRXRADDR hold the slave address and the slave register
982+
* The MRXADDR/MRXRADDR hold the target address and the target register
983983
* address in this case.
984984
*/
985985

@@ -1016,7 +1016,7 @@ static int rk3x_i2c_setup(struct rk3x_i2c *i2c, struct i2c_msg *msgs, int num)
10161016
addr |= 1; /* set read bit */
10171017

10181018
/*
1019-
* We have to transmit the slave addr first. Use
1019+
* We have to transmit the target addr first. Use
10201020
* MOD_REGISTER_TX for that purpose.
10211021
*/
10221022
i2c->mode = REG_CON_MOD_REGISTER_TX;
@@ -1160,9 +1160,9 @@ static u32 rk3x_i2c_func(struct i2c_adapter *adap)
11601160
}
11611161

11621162
static const struct i2c_algorithm rk3x_i2c_algorithm = {
1163-
.master_xfer = rk3x_i2c_xfer,
1164-
.master_xfer_atomic = rk3x_i2c_xfer_polling,
1165-
.functionality = rk3x_i2c_func,
1163+
.xfer = rk3x_i2c_xfer,
1164+
.xfer_atomic = rk3x_i2c_xfer_polling,
1165+
.functionality = rk3x_i2c_func,
11661166
};
11671167

11681168
static const struct rk3x_i2c_soc_data rv1108_soc_data = {

0 commit comments

Comments
 (0)