Skip to content

Commit b35814a

Browse files
Szilard Fabianjwrdegoede
authored andcommitted
platform/x86/fujitsu-laptop: Replace sprintf() with sysfs_emit()
As suggested by Documentation/filesystems/sysfs.rst sysfs_emit() should be used when formatting the value to be returned to user space. Signed-off-by: Szilard Fabian <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Jonathan Woithe <[email protected]> Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]> Reviewed-by: Hans de Goede <[email protected]> Signed-off-by: Hans de Goede <[email protected]>
1 parent 5cfac5a commit b35814a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/platform/x86/fujitsu-laptop.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -386,11 +386,11 @@ static ssize_t lid_show(struct device *dev, struct device_attribute *attr,
386386
struct fujitsu_laptop *priv = dev_get_drvdata(dev);
387387

388388
if (!(priv->flags_supported & FLAG_LID))
389-
return sprintf(buf, "unknown\n");
389+
return sysfs_emit(buf, "unknown\n");
390390
if (priv->flags_state & FLAG_LID)
391-
return sprintf(buf, "open\n");
391+
return sysfs_emit(buf, "open\n");
392392
else
393-
return sprintf(buf, "closed\n");
393+
return sysfs_emit(buf, "closed\n");
394394
}
395395

396396
static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
@@ -399,11 +399,11 @@ static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
399399
struct fujitsu_laptop *priv = dev_get_drvdata(dev);
400400

401401
if (!(priv->flags_supported & FLAG_DOCK))
402-
return sprintf(buf, "unknown\n");
402+
return sysfs_emit(buf, "unknown\n");
403403
if (priv->flags_state & FLAG_DOCK)
404-
return sprintf(buf, "docked\n");
404+
return sysfs_emit(buf, "docked\n");
405405
else
406-
return sprintf(buf, "undocked\n");
406+
return sysfs_emit(buf, "undocked\n");
407407
}
408408

409409
static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
@@ -412,11 +412,11 @@ static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
412412
struct fujitsu_laptop *priv = dev_get_drvdata(dev);
413413

414414
if (!(priv->flags_supported & FLAG_RFKILL))
415-
return sprintf(buf, "unknown\n");
415+
return sysfs_emit(buf, "unknown\n");
416416
if (priv->flags_state & FLAG_RFKILL)
417-
return sprintf(buf, "on\n");
417+
return sysfs_emit(buf, "on\n");
418418
else
419-
return sprintf(buf, "killed\n");
419+
return sysfs_emit(buf, "killed\n");
420420
}
421421

422422
static DEVICE_ATTR_RO(lid);

0 commit comments

Comments
 (0)