Skip to content

Commit b40c8e7

Browse files
zcjie1brauner
authored andcommitted
vfs: correct the comments of vfs_*() helpers
correct the comments of vfs_*() helpers in fs/namei.c, including: 1. vfs_create() 2. vfs_mknod() 3. vfs_mkdir() 4. vfs_rmdir() 5. vfs_symlink() All of them come from the same commit: 6521f89 "namei: prepare for idmapped mounts" The @dentRy is actually the dentry of child directory rather than base directory(parent directory), and thus the @dir has to be modified due to the change of @dentRy. Signed-off-by: Congjie Zhou <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Christian Brauner <[email protected]>
1 parent 5bc9ad7 commit b40c8e7

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

fs/namei.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3248,9 +3248,9 @@ static inline umode_t vfs_prepare_mode(struct mnt_idmap *idmap,
32483248
/**
32493249
* vfs_create - create new file
32503250
* @idmap: idmap of the mount the inode was found from
3251-
* @dir: inode of @dentry
3252-
* @dentry: pointer to dentry of the base directory
3253-
* @mode: mode of the new file
3251+
* @dir: inode of the parent directory
3252+
* @dentry: dentry of the child file
3253+
* @mode: mode of the child file
32543254
* @want_excl: whether the file must not yet exist
32553255
*
32563256
* Create a new file.
@@ -4047,9 +4047,9 @@ EXPORT_SYMBOL(user_path_create);
40474047
/**
40484048
* vfs_mknod - create device node or file
40494049
* @idmap: idmap of the mount the inode was found from
4050-
* @dir: inode of @dentry
4051-
* @dentry: pointer to dentry of the base directory
4052-
* @mode: mode of the new device node or file
4050+
* @dir: inode of the parent directory
4051+
* @dentry: dentry of the child device node
4052+
* @mode: mode of the child device node
40534053
* @dev: device number of device to create
40544054
*
40554055
* Create a device node or file.
@@ -4174,9 +4174,9 @@ SYSCALL_DEFINE3(mknod, const char __user *, filename, umode_t, mode, unsigned, d
41744174
/**
41754175
* vfs_mkdir - create directory
41764176
* @idmap: idmap of the mount the inode was found from
4177-
* @dir: inode of @dentry
4178-
* @dentry: pointer to dentry of the base directory
4179-
* @mode: mode of the new directory
4177+
* @dir: inode of the parent directory
4178+
* @dentry: dentry of the child directory
4179+
* @mode: mode of the child directory
41804180
*
41814181
* Create a directory.
41824182
*
@@ -4256,8 +4256,8 @@ SYSCALL_DEFINE2(mkdir, const char __user *, pathname, umode_t, mode)
42564256
/**
42574257
* vfs_rmdir - remove directory
42584258
* @idmap: idmap of the mount the inode was found from
4259-
* @dir: inode of @dentry
4260-
* @dentry: pointer to dentry of the base directory
4259+
* @dir: inode of the parent directory
4260+
* @dentry: dentry of the child directory
42614261
*
42624262
* Remove a directory.
42634263
*
@@ -4537,8 +4537,8 @@ SYSCALL_DEFINE1(unlink, const char __user *, pathname)
45374537
/**
45384538
* vfs_symlink - create symlink
45394539
* @idmap: idmap of the mount the inode was found from
4540-
* @dir: inode of @dentry
4541-
* @dentry: pointer to dentry of the base directory
4540+
* @dir: inode of the parent directory
4541+
* @dentry: dentry of the child symlink file
45424542
* @oldname: name of the file to link to
45434543
*
45444544
* Create a symlink.

0 commit comments

Comments
 (0)