Skip to content

Commit b44f687

Browse files
chleroympe
authored andcommitted
drm/i915/gem: Replace user_access_begin by user_write_access_begin
When i915_gem_execbuffer2_ioctl() is using user_access_begin(), that's only to perform unsafe_put_user() so use user_write_access_begin() in order to only open write access. Signed-off-by: Christophe Leroy <[email protected]> Reviewed-by: Kees Cook <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/ebf1250b6d4f351469fb339e5399d8b92aa8a1c1.1585898438.git.christophe.leroy@c-s.fr
1 parent 41cd780 commit b44f687

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2794,7 +2794,8 @@ i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data,
27942794
* And this range already got effectively checked earlier
27952795
* when we did the "copy_from_user()" above.
27962796
*/
2797-
if (!user_access_begin(user_exec_list, count * sizeof(*user_exec_list)))
2797+
if (!user_write_access_begin(user_exec_list,
2798+
count * sizeof(*user_exec_list)))
27982799
goto end;
27992800

28002801
for (i = 0; i < args->buffer_count; i++) {
@@ -2808,7 +2809,7 @@ i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data,
28082809
end_user);
28092810
}
28102811
end_user:
2811-
user_access_end();
2812+
user_write_access_end();
28122813
end:;
28132814
}
28142815

0 commit comments

Comments
 (0)