Skip to content

Commit b46c760

Browse files
Niklas CasselDamien Le Moal
authored andcommitted
ata: libata: drop superfluous ata_eh_request_sense() parameter
The parameter can easily be derived from struct ata_queued_cmd. Signed-off-by: Niklas Cassel <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent 630624c commit b46c760

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/ata/libata-eh.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1390,17 +1390,16 @@ unsigned int atapi_eh_tur(struct ata_device *dev, u8 *r_sense_key)
13901390
/**
13911391
* ata_eh_request_sense - perform REQUEST_SENSE_DATA_EXT
13921392
* @qc: qc to perform REQUEST_SENSE_SENSE_DATA_EXT to
1393-
* @cmd: scsi command for which the sense code should be set
13941393
*
13951394
* Perform REQUEST_SENSE_DATA_EXT after the device reported CHECK
13961395
* SENSE. This function is an EH helper.
13971396
*
13981397
* LOCKING:
13991398
* Kernel thread context (may sleep).
14001399
*/
1401-
static void ata_eh_request_sense(struct ata_queued_cmd *qc,
1402-
struct scsi_cmnd *cmd)
1400+
static void ata_eh_request_sense(struct ata_queued_cmd *qc)
14031401
{
1402+
struct scsi_cmnd *cmd = qc->scsicmd;
14041403
struct ata_device *dev = qc->dev;
14051404
struct ata_taskfile tf;
14061405
unsigned int err_mask;
@@ -1576,7 +1575,7 @@ static unsigned int ata_eh_analyze_tf(struct ata_queued_cmd *qc,
15761575
switch (qc->dev->class) {
15771576
case ATA_DEV_ZAC:
15781577
if (stat & ATA_SENSE)
1579-
ata_eh_request_sense(qc, qc->scsicmd);
1578+
ata_eh_request_sense(qc);
15801579
fallthrough;
15811580
case ATA_DEV_ATA:
15821581
if (err & ATA_ICRC)

0 commit comments

Comments
 (0)